Bump kpi-calculator to 0.4.3rc0#67
Merged
Merged
Conversation
Update integration tests to raise warning and guard against a pre-existing
simulation ValueError that surfaced with the updated dependencies.
- Guard warning tests against ValueError from simulator-core (skipped, not failed)
- Extract duplicate ValueError guard into _run_simulator_skip_on_value_error()
- Remove redundant AAA comments where no local arrange step exists
- Merge TestKPIOutputEsdlStructure and TestKPICostValues into a single
class to avoid running the simulator twice for identical conditions
- Add None guard for area.KPIs in setUpClass
- Restore pandas-stubs ~= 2.1.1 to dev deps (fixes mypy import-untyped error)
- Pin kpi-calculator to ~= 0.4.2 (stable release)
jarsarasty
force-pushed
the
update-kpi-version-to-0.4.3rc0
branch
from
4f0a025 to
e2cd84a
Compare
samvanderzwan
approved these changes
Jun 17, 2026
samvanderzwan
left a comment
samvanderzwan
left a comment
Contributor
There was a problem hiding this comment.
lgtm
Small comment on version change of pandastubs, but that is no stopper to merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.